opc/skelet
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Phase 1 评审修复：M2M clean() 校验 + 正确页面树测试(20 tests) + AGENTS.md 同步

Browse Source
This commit is contained in:
ila
2026-07-06 21:00:09 +08:00
parent a2d2cd226d
commit 6ec28c8374
5 changed files with 352 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/models.py
+16
View File
@@ -1,4 +1,5 @@
from django.db import models
from django.core.exceptions import ValidationError
from django.core.validators import MinValueValidator, MaxValueValidator
from modelcluster.fields import ParentalManyToManyField
from wagtail.models import Page
@@ -234,6 +235,21 @@ class SkeletonProjectPage(Page):
),
]
def clean(self):
super().clean()
if self.id is not None:
errors = {}
if not self.scenarios.exists():
errors["scenarios"] = ValidationError(
"At least one scenario is required."
)
if not self.languages.exists():
errors["languages"] = ValidationError(
"At least one language is required."
)
if errors:
raise ValidationError(errors)
class Meta:
verbose_name = "Skeleton Project"
core/tests.py
+82 -44
View File
@@ -4,12 +4,18 @@ from django.core.exceptions import ValidationError
from wagtail.models import Page
from home.models import HomePage
from core.models import (
Language,
Framework,
DatabaseOption,
SkeletonFeature,
ScenarioIndexPage,
ScenarioPage,
ProjectIndexPage,
SkeletonProjectPage,
ArticleIndexPage,
ArticlePage,
)
@@ -18,7 +24,6 @@ class LanguageTests(TestCase):
def test_create_language(self):
lang = Language.objects.create(name="Python", slug="python")
self.assertEqual(lang.name, "Python")
self.assertEqual(str(lang), "Python")
def test_slug_unique(self):
Language.objects.create(name="Python", slug="python")
@@ -30,7 +35,6 @@ class FrameworkTests(TestCase):
def test_create_framework(self):
fw = Framework.objects.create(name="Django", slug="django")
self.assertEqual(fw.name, "Django")
self.assertEqual(str(fw), "Django")
def test_slug_unique(self):
Framework.objects.create(name="Django", slug="django")
@@ -42,7 +46,6 @@ class DatabaseOptionTests(TestCase):
def test_create_database_option(self):
db = DatabaseOption.objects.create(name="PostgreSQL", slug="postgresql")
self.assertEqual(db.name, "PostgreSQL")
self.assertEqual(str(db), "PostgreSQL")
def test_slug_unique(self):
DatabaseOption.objects.create(name="PostgreSQL", slug="postgresql")
@@ -54,7 +57,6 @@ class SkeletonFeatureTests(TestCase):
def test_create_skeleton_feature(self):
feat = SkeletonFeature.objects.create(name="Docker", slug="docker")
self.assertEqual(feat.name, "Docker")
self.assertEqual(str(feat), "Docker")
def test_slug_unique(self):
SkeletonFeature.objects.create(name="Docker", slug="docker")
@@ -62,52 +64,63 @@ class SkeletonFeatureTests(TestCase):
SkeletonFeature.objects.create(name="Docker2", slug="docker")
class SkeletonProjectPageTests(TestCase):
class PageTreeMixin:
@classmethod
def setUpPageTree(cls):
cls.home = HomePage.objects.get(slug="home")
cls.scenario_index = ScenarioIndexPage(title="Scenarios", slug="scenarios")
cls.home.add_child(instance=cls.scenario_index)
cls.scenario = ScenarioPage(title="SaaS", slug="saas")
cls.scenario_index.add_child(instance=cls.scenario)
cls.project_index = ProjectIndexPage(title="Projects", slug="projects")
cls.home.add_child(instance=cls.project_index)
cls.article_index = ArticleIndexPage(title="Articles", slug="articles")
cls.home.add_child(instance=cls.article_index)
class SkeletonProjectPageTests(PageTreeMixin, TestCase):
@classmethod
def setUpTestData(cls):
cls.setUpPageTree()
cls.lang = Language.objects.create(name="Python", slug="python")
cls.lang2 = Language.objects.create(name="JavaScript", slug="javascript")
cls.fw = Framework.objects.create(name="Django", slug="django")
def _make_project(self, **kwargs):
defaults = {
"title": "Test Project",
"slug": "test-project",
"summary": "A test skeleton",
"github_url": "https://github.com/test/project",
"maturity": "stable",
"recommended_for": "Beginners",
"structure_score": 4,
"docs_score": 3,
"tests_score": 3,
"example_score": 2,
"dependency_score": 4,
"incremental_score": 3,
}
defaults.update(kwargs)
project = SkeletonProjectPage(**defaults)
self.project_index.add_child(instance=project)
return project
def test_valid_project_full_clean(self):
root = Page.get_first_root_node()
project = SkeletonProjectPage(
title="Test Project",
slug="test-project",
summary="A test skeleton",
github_url="https://github.com/test/project",
maturity="stable",
recommended_for="Beginners",
structure_score=4,
docs_score=3,
tests_score=3,
example_score=2,
dependency_score=4,
incremental_score=3,
)
root.add_child(instance=project)
project = self._make_project()
project.languages.add(self.lang)
project.scenarios.add(self.scenario)
try:
project.full_clean()
except ValidationError as e:
self.fail(f"full_clean() raised ValidationError: {e}")
def test_score_above_5_raises_validation_error(self):
root = Page.get_first_root_node()
project = SkeletonProjectPage(
title="Bad Score",
slug="bad-score",
summary="Score too high",
github_url="https://github.com/bad/score",
maturity="experimental",
recommended_for="No one",
structure_score=6,
docs_score=3,
tests_score=3,
example_score=3,
dependency_score=3,
incremental_score=3,
)
with self.assertRaises(ValidationError):
root.add_child(instance=project)
self._make_project(structure_score=6)
def test_total_score_equals_sum_of_six_scores(self):
project = SkeletonProjectPage(
@@ -126,12 +139,36 @@ class SkeletonProjectPageTests(TestCase):
)
self.assertEqual(project.total_score, 19)
def test_missing_scenarios_raises_error(self):
project = self._make_project()
project.languages.add(self.lang)
with self.assertRaises(ValidationError):
project.full_clean()
def test_missing_languages_raises_error(self):
project = self._make_project()
project.scenarios.add(self.scenario)
with self.assertRaises(ValidationError):
project.full_clean()
def test_all_m2m_set_passes(self):
project = self._make_project()
project.languages.add(self.lang)
project.scenarios.add(self.scenario)
project.frameworks.add(self.fw)
try:
project.full_clean()
except ValidationError:
self.fail("full_clean() should pass with all M2M set")
class ArticlePageTests(PageTreeMixin, TestCase):
@classmethod
def setUpTestData(cls):
cls.setUpPageTree()
cls.lang = Language.objects.create(name="Go", slug="go")
class ArticlePageTests(TestCase):
def test_create_article_with_related_project(self):
root = Page.get_first_root_node()
lang = Language.objects.create(name="Go", slug="go")
project = SkeletonProjectPage(
title="Related Project",
slug="related-project",
@@ -146,15 +183,16 @@ class ArticlePageTests(TestCase):
dependency_score=3,
incremental_score=3,
)
root.add_child(instance=project)
project.languages.add(lang)
self.project_index.add_child(instance=project)
project.languages.add(self.lang)
project.scenarios.add(self.scenario)
article = ArticlePage(
title="Test Article",
slug="test-article",
body="<p>Article body content.</p>",
)
root.add_child(instance=article)
self.article_index.add_child(instance=article)
article.related_projects.add(project)
self.assertEqual(article.related_projects.count(), 1)