fix: address phase 1 ai review

apps/ai/tests.py

@@ -13,6 +13,7 @@ from apps.ai.importers import import_ai_models_config
 from apps.ai.models import AiConfigAuditLog, AiModel, ModelAlias
 from apps.ai.providers import AiCapabilityError, ResolvedModel, get_provider, resolve_api_type
 from apps.ai.providers.openai_compatible import ChatCompletionsProvider, ImagesEditsProvider
+from apps.ai.providers.utils import resolution_to_size
 
 
 TEST_ENCRYPTION_KEY = Fernet.generate_key().decode("ascii")
@@ -54,6 +55,12 @@ class ProviderRegistryTests(SimpleTestCase):
         self.assertIsInstance(get_provider("auto", url), ChatCompletionsProvider)
 
 
+class ProviderUtilsTests(SimpleTestCase):
+    def test_resolution_to_size_normalizes_case(self):
+        self.assertEqual(resolution_to_size("1k"), "1024x1024")
+        self.assertEqual(resolution_to_size("512px"), "512x512")
+
+
 class ChatCompletionsProviderTests(SimpleTestCase):
     def test_generate_text_builds_chat_payload_and_cleans_titles(self):
         session = FakeSession(
@@ -92,6 +99,54 @@ class ChatCompletionsProviderTests(SimpleTestCase):
         self.assertFalse(request["json"]["stream"])
         self.assertEqual(request["json"]["temperature"], 0.2)
 
+    def test_parameters_cannot_override_core_chat_payload_fields(self):
+        session = FakeSession(
+            FakeResponse(
+                {
+                    "choices": [
+                        {"message": {"content": "1. Safe Title"}}
+                    ]
+                }
+            )
+        )
+        provider = ChatCompletionsProvider(session=session)
+        model = ResolvedModel(
+            name="GPT-5.5 text",
+            url="https://api.vectorengine.ai/v1",
+            model="gpt-5.5",
+            api_key="test-key",
+            api_type="chat",
+            extra_body={
+                "model": "bad-extra-model",
+                "stream": True,
+                "temperature": 0.1,
+            },
+        )
+
+        provider.generate_text(
+            "Generate titles",
+            model,
+            parameters={
+                "model": "gpt-image-2",
+                "n": 5,
+                "messages": [],
+                "stream": True,
+                "size": "4096x4096",
+                "temperature": 0.2,
+            },
+        )
+
+        payload = session.posts[0]["json"]
+        self.assertEqual(payload["model"], "gpt-5.5")
+        self.assertFalse(payload["stream"])
+        self.assertEqual(
+            payload["messages"],
+            [{"role": "user", "content": [{"type": "text", "text": "Generate titles"}]}],
+        )
+        self.assertNotIn("n", payload)
+        self.assertNotIn("size", payload)
+        self.assertEqual(payload["temperature"], 0.2)
+
     def test_generate_image_parses_chat_multimodal_data_url(self):
         generated = b"generated-image"
         encoded = base64.b64encode(generated).decode("ascii")
@@ -172,6 +227,44 @@ class ImagesEditsProviderTests(SimpleTestCase):
             ("source.png", b"source-image", "image/png"),
         )
 
+    def test_parameters_cannot_override_core_images_edits_fields(self):
+        generated = b"edited-image"
+        encoded = base64.b64encode(generated).decode("ascii")
+        session = FakeSession(FakeResponse({"data": [{"b64_json": encoded}]}))
+        provider = ImagesEditsProvider(session=session)
+        model = ResolvedModel(
+            name="GPT Image 2",
+            url="https://api.vectorengine.ai/v1/images/edits",
+            model="gpt-image-2",
+            api_key="test-key",
+            api_type="images_edits",
+            extra_body={
+                "model": "bad-extra-model",
+                "n": "9",
+                "size": "4096x4096",
+                "temperature": 0.3,
+            },
+        )
+
+        provider.generate_image(
+            "Replace background",
+            model,
+            image=b"source-image",
+            resolution="1k",
+            parameters={
+                "model": "bad-parameter-model",
+                "n": "3",
+                "size": "1x1",
+                "temperature": 0.7,
+            },
+        )
+
+        data = session.posts[0]["data"]
+        self.assertEqual(data["model"], "gpt-image-2")
+        self.assertEqual(data["n"], "1")
+        self.assertEqual(data["size"], "1024x1024")
+        self.assertEqual(data["temperature"], 0.7)
+
     def test_images_edits_requires_input_image(self):
         provider = ImagesEditsProvider(session=FakeSession())
         model = ResolvedModel(
@@ -367,7 +460,7 @@ class AiModelsImportTests(TestCase):
         )
         image_alias = ModelAlias.objects.get(
             operation_type=ModelAlias.OperationType.IMAGE,
-            alias="image-standard",
+            alias="image-hd",
         )
         self.assertEqual(title_alias.ai_model, text_model)
         self.assertEqual(image_alias.ai_model, image_model)
@@ -523,7 +616,7 @@ class AiConfigAuditAdminTests(TestCase):
         )
         alias = ModelAlias.objects.create(
             operation_type=ModelAlias.OperationType.IMAGE,
-            alias="image-standard",
+            alias="image-hd",
             ai_model=text_model,
         )
         alias.ai_model = image_model
@@ -588,3 +681,27 @@ class AiGenerationSmokeCommandTests(TestCase):
         self.assertNotIn("Bearer", text)
         self.assertEqual(AiModel.objects.count(), 0)
         self.assertEqual(ModelAlias.objects.count(), 0)
+
+    def test_recorded_image_smoke_runs_through_alias_and_provider_without_persisting(self):
+        output = io.StringIO()
+
+        call_command(
+            "smoke_ai_generation",
+            "image",
+            "--recorded",
+            "--prompt",
+            "生成测试图片",
+            stdout=output,
+        )
+
+        text = output.getvalue()
+        self.assertIn("Smoke generation OK", text)
+        self.assertIn("mode=recorded", text)
+        self.assertIn("operation=image", text)
+        self.assertIn("alias=t-105-recorded-image-", text)
+        self.assertIn("model_used=recorded-image-model", text)
+        self.assertIn("image_bytes=20", text)
+        self.assertNotIn("sk-recorded-placeholder", text)
+        self.assertNotIn("Bearer", text)
+        self.assertEqual(AiModel.objects.count(), 0)
+        self.assertEqual(ModelAlias.objects.count(), 0)