feat: 实现 Android 设备搜索 (#21)

client/test/test_settings_ui_event.py

@@ -8,13 +8,17 @@ from pathlib import Path
 
 os.environ.setdefault("QT_QPA_PLATFORM", "offscreen")
 
-from PyQt5.QtCore import QTimer
+from PyQt5.QtCore import Qt, QTimer
 from PyQt5.QtTest import QTest
 from PyQt5.QtWidgets import QApplication
 
+from src.android_device_service import (
+    AndroidDevice,
+    AndroidDeviceSearchError,
+)
 from src.mock_admin_gateway import MockAdminGateway
 from src.settings_repository import SettingsRepository
-from src.settings_ui import SettingsPage
+from src.settings_ui import AndroidDeviceRow, SettingsPage
 
 
 class SlowMockAdminGateway(MockAdminGateway):
@@ -25,6 +29,34 @@ class SlowMockAdminGateway(MockAdminGateway):
         return super().register_client(client, capabilities)
 
 
+class SequenceAndroidDeviceService:
+    """按顺序返回搜索结果，便于测试刷新行为。"""
+
+    def __init__(self, results):
+        self._results = list(results)
+        self.call_count = 0
+
+    def search(self, _is_cancelled=None):
+        result = self._results[min(self.call_count, len(self._results) - 1)]
+        self.call_count += 1
+        if isinstance(result, Exception):
+            raise result
+        return result
+
+
+class SlowAndroidDeviceService:
+    """模拟较慢的 ADB 搜索。"""
+
+    def __init__(self, delay=0.08):
+        self.delay = delay
+        self.call_count = 0
+
+    def search(self, _is_cancelled=None):
+        self.call_count += 1
+        time.sleep(self.delay)
+        return [AndroidDevice("USB-001", "USB", "Pixel 8", "14")]
+
+
 class SettingsPageEventTest(unittest.TestCase):
     @classmethod
     def setUpClass(cls):
@@ -144,6 +176,151 @@ class SettingsPageEventTest(unittest.TestCase):
         self.assertEqual(page.currentDeviceStatusLabel.text(), status_before_close)
         page.deleteLater()
 
+    def test_search_updates_table_and_device_status(self):
+        service = SequenceAndroidDeviceService(
+            [[
+                AndroidDevice("USB-001", "USB", "Pixel 8", "14"),
+                AndroidDevice(
+                    "192.168.0.173:5555",
+                    "Wi-Fi",
+                    status="offline",
+                ),
+            ]]
+        )
+        page = SettingsPage(
+            settings_repository=self.repository,
+            admin_gateway=MockAdminGateway(),
+            android_device_service=service,
+        )
+
+        page.searchButton.click()
+        self.assertFalse(page.searchButton.isEnabled())
+        self._wait_until(lambda: page.eventBinder._search_thread is None)
+
+        model = page.deviceTableModel
+        self.assertEqual(model.rowCount(), 2)
+        self.assertEqual(model.device_for_serial("USB-001").model, "Pixel 8")
+        self.assertEqual(
+            model.device_for_serial("192.168.0.173:5555").status,
+            "offline",
+        )
+        offline_index = model.index(
+            model.row_for_serial("192.168.0.173:5555"), 0
+        )
+        self.assertFalse(
+            model.setData(offline_index, Qt.Checked, Qt.CheckStateRole)
+        )
+        self.assertEqual(
+            page.deviceStatusLabel.text(),
+            "搜索完成：找到 2 台 Android 设备",
+        )
+        self.assertTrue(page.searchButton.isEnabled())
+        page.eventBinder.shutdown()
+        page.deleteLater()
+
+    def test_empty_search_keeps_placeholder_rows(self):
+        service = SequenceAndroidDeviceService([[]])
+        page = SettingsPage(
+            settings_repository=self.repository,
+            admin_gateway=MockAdminGateway(),
+            android_device_service=service,
+        )
+
+        page.searchButton.click()
+        self._wait_until(lambda: page.eventBinder._search_thread is None)
+
+        self.assertGreaterEqual(page.deviceTableModel.rowCount(), 1)
+        self.assertIn("未找到 Android 设备", page.deviceStatusLabel.text())
+        page.eventBinder.shutdown()
+        page.deleteLater()
+
+    def test_search_failure_preserves_previous_rows(self):
+        service = SequenceAndroidDeviceService(
+            [AndroidDeviceSearchError("未找到 adb，请检查 PATH 后重试")]
+        )
+        page = SettingsPage(
+            settings_repository=self.repository,
+            admin_gateway=MockAdminGateway(),
+            android_device_service=service,
+        )
+        page.set_android_devices(
+            [AndroidDeviceRow("USB-OLD", "USB", "Old Phone", "12")]
+        )
+
+        page.searchButton.click()
+        self._wait_until(lambda: page.eventBinder._search_thread is None)
+
+        self.assertIsNotNone(
+            page.deviceTableModel.device_for_serial("USB-OLD")
+        )
+        self.assertIn("搜索失败：未找到 adb", page.deviceStatusLabel.text())
+        self.assertIn("设备列表未更改", page.deviceStatusLabel.text())
+        page.eventBinder.shutdown()
+        page.deleteLater()
+
+    def test_search_preserves_or_clears_checked_device_by_serial(self):
+        connected = AndroidDevice("USB-001", "USB", "Pixel 8", "14")
+        service = SequenceAndroidDeviceService([[connected], [connected], []])
+        page = SettingsPage(
+            settings_repository=self.repository,
+            admin_gateway=MockAdminGateway(),
+            android_device_service=service,
+        )
+
+        page.searchButton.click()
+        self._wait_until(lambda: page.eventBinder._search_thread is None)
+        page.deviceTableModel.set_checked_serial("USB-001")
+
+        page.searchButton.click()
+        self._wait_until(lambda: page.eventBinder._search_thread is None)
+        self.assertEqual(page.deviceTableModel.checked_serial, "USB-001")
+
+        page.searchButton.click()
+        self._wait_until(lambda: page.eventBinder._search_thread is None)
+        self.assertEqual(page.deviceTableModel.checked_serial, "")
+        page.eventBinder.shutdown()
+        page.deleteLater()
+
+    def test_slow_search_does_not_block_or_start_twice(self):
+        service = SlowAndroidDeviceService()
+        page = SettingsPage(
+            settings_repository=self.repository,
+            admin_gateway=MockAdminGateway(),
+            android_device_service=service,
+        )
+        timer_fired = []
+        QTimer.singleShot(10, lambda: timer_fired.append(True))
+
+        page.searchButton.click()
+        page.eventBinder._request_search()
+        self._wait_until(lambda: bool(timer_fired), timeout_ms=500)
+        self._wait_until(lambda: page.eventBinder._search_thread is None)
+
+        self.assertTrue(timer_fired)
+        self.assertEqual(service.call_count, 1)
+        page.eventBinder.shutdown()
+        page.deleteLater()
+
+    def test_shutdown_ignores_late_search_result(self):
+        service = SlowAndroidDeviceService()
+        page = SettingsPage(
+            settings_repository=self.repository,
+            admin_gateway=MockAdminGateway(),
+            android_device_service=service,
+        )
+
+        page.searchButton.click()
+        self._wait_until(lambda: page.eventBinder._search_thread is not None)
+        status_before_close = page.deviceStatusLabel.text()
+        page.eventBinder.shutdown()
+        QTest.qWait(120)
+
+        self.assertEqual(page.deviceStatusLabel.text(), status_before_close)
+        self.assertIsNone(
+            page.deviceTableModel.device_for_serial("USB-001")
+        )
+        page.deleteLater()
+
 
 if __name__ == "__main__":
     unittest.main()